aboutsummaryrefslogtreecommitdiffstats
path: root/arch/sh/drivers/platform_early.c
diff options
context:
space:
mode:
authorGuenter Roeck <linux@roeck-us.net>2019-12-03 12:58:52 -0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-12-10 15:51:20 +0100
commiteecd37e105f0137af0d1b726bf61ff35d1d7d2eb (patch)
treebbc2c130cb73a5071606293e56e5036659951cdf /arch/sh/drivers/platform_early.c
parentof/platform: Unconditionally pause/resume sync state during kernel init (diff)
downloadlinux-dev-eecd37e105f0137af0d1b726bf61ff35d1d7d2eb.tar.xz
linux-dev-eecd37e105f0137af0d1b726bf61ff35d1d7d2eb.zip
drivers: Fix boot problem on SuperH
SuperH images crash too eearly to display any console output. Bisect points to commit 507fd01d5333 ("drivers: move the early platform device support to arch/sh"). An analysis of that patch suggests that early_platform_cleanup() is now called at the wrong time. Restoring its call point fixes the problem. Cc: Bartosz Golaszewski <brgl@bgdev.pl> Fixes: 507fd01d5333 ("drivers: move the early platform device support to arch/sh") Tested-by: Geert Uytterhoeven <geert+renesas@glider.be> Signed-off-by: Guenter Roeck <linux@roeck-us.net> Acked-by: Rob Landley <rob@landley.net> Link: https://lore.kernel.org/r/20191203205852.15659-1-linux@roeck-us.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to '')
-rw-r--r--arch/sh/drivers/platform_early.c11
1 files changed, 2 insertions, 9 deletions
diff --git a/arch/sh/drivers/platform_early.c b/arch/sh/drivers/platform_early.c
index f6d148451dfc..f3dc3f25b3ff 100644
--- a/arch/sh/drivers/platform_early.c
+++ b/arch/sh/drivers/platform_early.c
@@ -325,9 +325,9 @@ int __init sh_early_platform_driver_probe(char *class_str,
}
/**
- * sh_early_platform_cleanup - clean up early platform code
+ * early_platform_cleanup - clean up early platform code
*/
-static int __init sh_early_platform_cleanup(void)
+void __init early_platform_cleanup(void)
{
struct platform_device *pd, *pd2;
@@ -337,11 +337,4 @@ static int __init sh_early_platform_cleanup(void)
list_del(&pd->dev.devres_head);
memset(&pd->dev.devres_head, 0, sizeof(pd->dev.devres_head));
}
-
- return 0;
}
-/*
- * This must happen once after all early devices are probed but before probing
- * real platform devices.
- */
-subsys_initcall(sh_early_platform_cleanup);