diff options
| author |   David S. Miller <davem@sunset.davemloft.net> | 2007-03-19 13:27:33 -0700 |
|---|---|---|
| committer | David S. Miller <davem@sunset.davemloft.net> | 2007-03-19 13:27:33 -0700 |
| commit | 24d559cac4d741d60ec85e927974408020a2f060 (patch) | |
| tree | e01419724e2da6c817d525756e92d584d41c03eb /arch/sparc64/lib/NGpage.S | |
| parent | [PATCH] Fix build error due to not including <linux/errno.h> (diff) | |
| download | linux-dev-24d559cac4d741d60ec85e927974408020a2f060.tar.xz linux-dev-24d559cac4d741d60ec85e927974408020a2f060.zip | |
[SPARC64]: store-init needs trailing membar.
The manual says that it is required and we actually have crash reports
where loads see stale data due to not having membars here.
In one case the networking does:
memset(skb, 0, offsetof(struct sk_buff, truesize));
and then some code later checks skb->nohdr for zero, but it's still
the value that was there before the memset().
Note that arch/sparc64/lib/xor.S already got this right.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | arch/sparc64/lib/NGpage.S | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/arch/sparc64/lib/NGpage.S b/arch/sparc64/lib/NGpage.S index 7d7c3bb8dcbf..8ce3a0c9c537 100644 --- a/arch/sparc64/lib/NGpage.S +++ b/arch/sparc64/lib/NGpage.S @@ -41,6 +41,7 @@ NGcopy_user_page: /* %o0=dest, %o1=src, %o2=vaddr */ subcc %g7, 64, %g7 bne,pt %xcc, 1b add %o0, 32, %o0 + membar #Sync retl nop @@ -63,6 +64,7 @@ NGclear_user_page: /* %o0=dest, %o1=vaddr */ subcc %g7, 64, %g7 bne,pt %xcc, 1b add %o0, 32, %o0 + membar #Sync retl nop |