diff options
| author |   Paul Mundt <lethal@linux-sh.org> | 2009-10-05 19:23:06 +0900 |
|---|---|---|
| committer |   Frederic Weisbecker <fweisbec@gmail.com> | 2009-11-03 18:05:44 +0100 |
| commit | 41a48d14f6991020c9bb6b93e289ca5b411ed09a (patch) | |
| tree | b9460ce77ef52c26688abd76e615f006558dd5ae /arch/x86/kernel/process.c | |
| parent | perf/core: Provide a kernel-internal interface to get to performance counters (diff) | |
| download | linux-dev-41a48d14f6991020c9bb6b93e289ca5b411ed09a.tar.xz linux-dev-41a48d14f6991020c9bb6b93e289ca5b411ed09a.zip | |
x86/hw-breakpoints: Actually flush thread breakpoints in flush_thread().
flush_thread() tries to do a TIF_DEBUG check before calling in to
flush_thread_hw_breakpoint() (which subsequently clears the thread flag),
but for some reason, the x86 code is manually clearing TIF_DEBUG
immediately before the test, so this path will never be taken.
This kills off the erroneous clear_tsk_thread_flag() and lets
flush_thread_hw_breakpoint() actually get invoked.
Presumably folks were getting lucky with testing and the
free_thread_info() -> free_thread_xstate() path was taking care of the
flush there.
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Acked-by: "K.Prasad" <prasad@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Alan Stern <stern@rowland.harvard.edu>
LKML-Reference: <20091005102306.GA7889@linux-sh.org>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Diffstat (limited to '')
| -rw-r--r-- | arch/x86/kernel/process.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c index 2275ce5776de..cf8ee0016307 100644 --- a/arch/x86/kernel/process.c +++ b/arch/x86/kernel/process.c @@ -107,8 +107,6 @@ void flush_thread(void) } #endif - clear_tsk_thread_flag(tsk, TIF_DEBUG); - if (unlikely(test_tsk_thread_flag(tsk, TIF_DEBUG))) flush_thread_hw_breakpoint(tsk); memset(tsk->thread.tls_array, 0, sizeof(tsk->thread.tls_array)); |