diff options
| author |   Tejun Heo <htejun@gmail.com> | 2007-11-08 11:20:18 +0900 |
|---|---|---|
| committer |   Jeff Garzik <jeff@garzik.org> | 2007-11-08 13:08:41 -0500 |
| commit | 1974e20161a2c097c481d2ff711de7db56cb2cd6 (patch) | |
| tree | f2e129f13f222f23f8b9d0de12067bdb1b2cbc79 /drivers/ata/libata-core.c | |
| parent | libata: pata_platform: Support polling-mode configuration. (diff) | |
| download | linux-dev-1974e20161a2c097c481d2ff711de7db56cb2cd6.tar.xz linux-dev-1974e20161a2c097c481d2ff711de7db56cb2cd6.zip | |
libata: skip 0xff polling for PATA controllers
In a presentation of true workmanship, pata_ali asserts IRQ
permanantly if the TF status register is read more than once when
there's no device attached to the port.
Avoid waiting polling for !0xff if it's PATA. It's needed only for
some rare SATA devices anyway.
This problem is reported by Luca Tettamanti in bugzilla bug 9298.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Tested-By: Luca Tettamanti <kronos.it@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/ata/libata-core.c | 16 |
1 files changed, 11 insertions, 5 deletions
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 89fd0e9ed746..fd332612d64a 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -3373,14 +3373,20 @@ void ata_wait_after_reset(struct ata_port *ap, unsigned long deadline) * to clear 0xff after reset. For example, HHD424020F7SV00 * iVDR needs >= 800ms while. Quantum GoVault needs even more * than that. + * + * Note that some PATA controllers (pata_ali) explode if + * status register is read more than once when there's no + * device attached. */ - while (1) { - u8 status = ata_chk_status(ap); + if (ap->flags & ATA_FLAG_SATA) { + while (1) { + u8 status = ata_chk_status(ap); - if (status != 0xff || time_after(jiffies, deadline)) - return; + if (status != 0xff || time_after(jiffies, deadline)) + return; - msleep(50); + msleep(50); + } } } |