diff options
| author |   Sebastian Andrzej Siewior <bigeasy@linutronix.de> | 2020-11-16 17:21:16 +0100 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2020-11-18 16:43:59 -0800 |
| commit | 2de680dea6a888271087521a9501a74af57fa076 (patch) | |
| tree | ff45981fe756f42c893c2176adb2e821f84af4d9 /drivers/atm | |
| parent | atm: nicstar: Replace in_interrupt() usage (diff) | |
| download | linux-dev-2de680dea6a888271087521a9501a74af57fa076.tar.xz linux-dev-2de680dea6a888271087521a9501a74af57fa076.zip | |
atm: lanai: Remove in_interrupt() usage
lanai_shutdown_tx_vci() uses in_interrupt() to issue a warning message
if the function was used in context in which it is not safe to sleep.
The usage of in_interrupt() in driver code is deprecated as it can not always
detect all states where it is not allowed to sleep.
msleep() has debug code which will trigger a warning if used in bad
context.
Remove in_interrupt().
Cc: Chas Williams <3chas3@gmail.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/atm')
| -rw-r--r-- | drivers/atm/lanai.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/atm/lanai.c b/drivers/atm/lanai.c index ac811cfa6843..d7277c26e423 100644 --- a/drivers/atm/lanai.c +++ b/drivers/atm/lanai.c @@ -765,8 +765,7 @@ static void lanai_shutdown_tx_vci(struct lanai_dev *lanai, struct sk_buff *skb; unsigned long flags, timeout; int read, write, lastread = -1; - APRINTK(!in_interrupt(), - "lanai_shutdown_tx_vci called w/o process context!\n"); + if (lvcc->vbase == NULL) /* We were never bound to a VCI */ return; /* 15.2.1 - wait for queue to drain */ |