diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2012-12-17 16:04:21 -0800 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@linux-foundation.org> | 2012-12-17 17:15:26 -0800 |
| commit | 31279b1457f992f24eee8d45ddd647f5fce42cf6 (patch) | |
| tree | 25e8286f5e1fc6e01219eac7452b043a62aae90e /drivers/block/aoe/aoedev.c | |
| parent | aoe: update internal version number to 81 (diff) | |
| download | linux-dev-31279b1457f992f24eee8d45ddd647f5fce42cf6.tar.xz linux-dev-31279b1457f992f24eee8d45ddd647f5fce42cf6.zip | |
aoe: fix use after free in aoedev_by_aoeaddr()
We should return NULL on failure instead of returning a freed pointer.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ed Cashin <ecashin@coraid.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/block/aoe/aoedev.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c index e66ccbf41a50..98f2965778b9 100644 --- a/drivers/block/aoe/aoedev.c +++ b/drivers/block/aoe/aoedev.c @@ -461,6 +461,7 @@ aoedev_by_aoeaddr(ulong maj, int min, int do_alloc) d->targets = kcalloc(NTARGETS, sizeof(*d->targets), GFP_ATOMIC); if (!d->targets) { kfree(d); + d = NULL; goto out; } d->ntargets = NTARGETS; |