diff options
| author |   NeilBrown <neilb@suse.com> | 2017-06-18 14:38:58 +1000 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2017-06-18 12:40:59 -0600 |
| commit | 8cb0defbaa8d4778c7474677cbb93d8cd602a2a6 (patch) | |
| tree | 370c172503752131603c2e9f00a902143ebefe9c /drivers/block/drbd/drbd_req.h | |
| parent | rbd: use bio_clone_fast() instead of bio_clone() (diff) | |
| download | linux-dev-8cb0defbaa8d4778c7474677cbb93d8cd602a2a6.tar.xz linux-dev-8cb0defbaa8d4778c7474677cbb93d8cd602a2a6.zip | |
drbd: use bio_clone_fast() instead of bio_clone()
drbd does not modify the bi_io_vec of the cloned bio,
so there is no need to clone that part. So bio_clone_fast()
is the better choice.
For bio_clone_fast() we need to specify a bio_set.
We could use fs_bio_set, which bio_clone() uses, or
drbd_md_io_bio_set, which drbd uses for metadata, but it is
generally best to avoid sharing bio_sets unless you can
be certain that there are no interdependencies.
So create a new bio_set, drbd_io_bio_set, and use bio_clone_fast().
Also remove a "XXX cannot fail ???" comment because it definitely
cannot fail - bio_clone_fast() doesn't fail if the GFP flags allow for
sleeping.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to '')
| -rw-r--r-- | drivers/block/drbd/drbd_req.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/block/drbd/drbd_req.h b/drivers/block/drbd/drbd_req.h index eb49e7f2da91..9e1866ab238f 100644 --- a/drivers/block/drbd/drbd_req.h +++ b/drivers/block/drbd/drbd_req.h @@ -263,7 +263,7 @@ enum drbd_req_state_bits { static inline void drbd_req_make_private_bio(struct drbd_request *req, struct bio *bio_src) { struct bio *bio; - bio = bio_clone(bio_src, GFP_NOIO); /* XXX cannot fail?? */ + bio = bio_clone_fast(bio_src, GFP_NOIO, drbd_io_bio_set); req->private_bio = bio; |