diff options
| author |   Alexey Dobriyan <adobriyan@gmail.com> | 2006-12-06 20:36:21 -0800 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@woody.osdl.org> | 2006-12-07 08:39:33 -0800 |
| commit | b4178ab58aa81f4ed3c75c48940682fe3b45d880 (patch) | |
| tree | d9bd5827ee1f9a36bf9958a56760f6206272cc2f /drivers/block/paride/paride.c | |
| parent | [PATCH] paride: rename pi_register() and pi_unregister() (diff) | |
| download | linux-dev-b4178ab58aa81f4ed3c75c48940682fe3b45d880.tar.xz linux-dev-b4178ab58aa81f4ed3c75c48940682fe3b45d880.zip | |
[PATCH] paride_register(): shuffle return values
paride_register() returns 1 on success, 0 on failure and module init
code looks like
static int __init foo_init(void)
{
return paride_register(&foo) - 1;
}
which is not what one get used to. Converted to usual 0/-E convention.
In case of kbic driver, unwind registration. It was just
return (paride_register(&k951)||paride_register(&k971))-1;
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/block/paride/paride.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/block/paride/paride.c b/drivers/block/paride/paride.c index 55cabfb60cc5..e4c55e050126 100644 --- a/drivers/block/paride/paride.c +++ b/drivers/block/paride/paride.c @@ -237,19 +237,19 @@ int paride_register(PIP * pr) if (protocols[k] && !strcmp(pr->name, protocols[k]->name)) { printk("paride: %s protocol already registered\n", pr->name); - return 0; + return -1; } k = 0; while ((k < MAX_PROTOS) && (protocols[k])) k++; if (k == MAX_PROTOS) { printk("paride: protocol table full\n"); - return 0; + return -1; } protocols[k] = pr; pr->index = k; printk("paride: %s registered as protocol %d\n", pr->name, k); - return 1; + return 0; } EXPORT_SYMBOL(paride_register); |