diff options
| author |   Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2022-07-05 22:51:39 +0200 |
|---|---|---|
| committer |   Herbert Xu <herbert@gondor.apana.org.au> | 2022-07-15 16:43:20 +0800 |
| commit | 25edb4cddb0f3deb260b52106b73c3d0f4968489 (patch) | |
| tree | a07761db75b29cf86a9b12fa85377c62436e703c /drivers/crypto/atmel-sha.c | |
| parent | crypto: atmel-aes - Drop if with an always false condition (diff) | |
| download | linux-dev-25edb4cddb0f3deb260b52106b73c3d0f4968489.tar.xz linux-dev-25edb4cddb0f3deb260b52106b73c3d0f4968489.zip | |
crypto: atmel-sha - Drop if with an always false condition
The remove callback is only called after probe completed successfully.
In this case platform_set_drvdata() was called with a non-NULL argument
and so sha_dd is never NULL.
This is a preparation for making platform remove callbacks return void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to '')
| -rw-r--r-- | drivers/crypto/atmel-sha.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c index d1628112dacc..e054e0ac6fc2 100644 --- a/drivers/crypto/atmel-sha.c +++ b/drivers/crypto/atmel-sha.c @@ -2669,8 +2669,7 @@ static int atmel_sha_remove(struct platform_device *pdev) struct atmel_sha_dev *sha_dd; sha_dd = platform_get_drvdata(pdev); - if (!sha_dd) - return -ENODEV; + spin_lock(&atmel_sha.lock); list_del(&sha_dd->list); spin_unlock(&atmel_sha.lock); |