diff options
| author |   Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2022-07-05 22:51:40 +0200 |
|---|---|---|
| committer |   Herbert Xu <herbert@gondor.apana.org.au> | 2022-07-15 16:43:20 +0800 |
| commit | 515f4fc66bf176b91d24d89deddc18e0be12543f (patch) | |
| tree | d3cb878e70360afd601a320bd0c9c01ce4f9d418 /drivers/crypto/atmel-tdes.c | |
| parent | crypto: atmel-sha - Drop if with an always false condition (diff) | |
| download | linux-dev-515f4fc66bf176b91d24d89deddc18e0be12543f.tar.xz linux-dev-515f4fc66bf176b91d24d89deddc18e0be12543f.zip | |
crypto: atmel-tdes - Drop if with an always false condition
The remove callback is only called after probe completed successfully.
In this case platform_set_drvdata() was called with a non-NULL argument
and so tdes_dd is never NULL.
This is a preparation for making platform remove callbacks return void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to '')
| -rw-r--r-- | drivers/crypto/atmel-tdes.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c index 9fd7b8e439d2..a5e78aa08bf0 100644 --- a/drivers/crypto/atmel-tdes.c +++ b/drivers/crypto/atmel-tdes.c @@ -1266,8 +1266,7 @@ static int atmel_tdes_remove(struct platform_device *pdev) struct atmel_tdes_dev *tdes_dd; tdes_dd = platform_get_drvdata(pdev); - if (!tdes_dd) - return -ENODEV; + spin_lock(&atmel_tdes.lock); list_del(&tdes_dd->list); spin_unlock(&atmel_tdes.lock); |