diff options
| author |   Daniel Vetter <daniel.vetter@ffwll.ch> | 2019-12-13 18:26:04 +0100 |
|---|---|---|
| committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2019-12-17 17:26:08 +0100 |
| commit | e529878e4bc156ea021791a840b2f43f8fe4840d (patch) | |
| tree | 63f306f20a0dc4797027dff8fb025349ed9ae55b /drivers/gpu/drm/arm/malidp_planes.c | |
| parent | drm/etnaviv: Use dma_resv locking wrappers (diff) | |
| download | linux-dev-e529878e4bc156ea021791a840b2f43f8fe4840d.tar.xz linux-dev-e529878e4bc156ea021791a840b2f43f8fe4840d.zip | |
drm/malidp: plane_state->fb iff plane_state->crtc
Checking both is one too much, so wrap a WARN_ON around it to stope
the copypasta.
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Brian Starkey <brian.starkey@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191213172612.1514842-2-daniel.vetter@ffwll.ch
Diffstat (limited to '')
| -rw-r--r-- | drivers/gpu/drm/arm/malidp_planes.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c index 3c70a53813bf..37715cc6064e 100644 --- a/drivers/gpu/drm/arm/malidp_planes.c +++ b/drivers/gpu/drm/arm/malidp_planes.c @@ -512,7 +512,7 @@ static int malidp_de_plane_check(struct drm_plane *plane, int i, ret; unsigned int block_w, block_h; - if (!state->crtc || !state->fb) + if (!state->crtc || WARN_ON(!state->fb)) return 0; fb = state->fb; |