aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/gpu/drm/i915/intel_sdvo.c
diff options
context:
space:
mode:
authorVille Syrjälä <ville.syrjala@linux.intel.com>2019-04-09 17:40:52 +0300
committerVille Syrjälä <ville.syrjala@linux.intel.com>2019-06-07 20:40:53 +0300
commit700bbf83eabd26f918a783f69ed2a85fcb28bf7f (patch)
tree45c7c74e479979ed12e52dbe005847cce25d21bd /drivers/gpu/drm/i915/intel_sdvo.c
parentdrm/i915/sdvo: Check that we have space for the infoframe (diff)
downloadlinux-dev-700bbf83eabd26f918a783f69ed2a85fcb28bf7f.tar.xz
linux-dev-700bbf83eabd26f918a783f69ed2a85fcb28bf7f.zip
drm/i915/sdvo: Don't unpack stack garbage
Pass the length returned by intel_sdvo_read_infoframe() to hdmi_infoframe_unpack() so that we don't try to unpack any leftover stack garbage. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190409144054.24561-6-ville.syrjala@linux.intel.com Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Diffstat (limited to '')
-rw-r--r--drivers/gpu/drm/i915/intel_sdvo.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
index bc1ef161df32..1c8ad680813c 100644
--- a/drivers/gpu/drm/i915/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/intel_sdvo.c
@@ -1132,7 +1132,7 @@ static void intel_sdvo_get_avi_infoframe(struct intel_sdvo *intel_sdvo,
crtc_state->infoframes.enable |=
intel_hdmi_infoframe_enable(HDMI_INFOFRAME_TYPE_AVI);
- ret = hdmi_infoframe_unpack(frame, sdvo_data, sizeof(sdvo_data));
+ ret = hdmi_infoframe_unpack(frame, sdvo_data, len);
if (ret) {
DRM_DEBUG_KMS("Failed to unpack AVI infoframe\n");
return;