diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2022-07-08 11:41:06 +0300 |
|---|---|---|
| committer |   Zhenyu Wang <zhenyuw@linux.intel.com> | 2022-07-11 13:05:05 +0800 |
| commit | e87197fbd137c888fd6c871c72fe7e89445dd015 (patch) | |
| tree | 702bb611de2b14daeb7bccbfcd64a521d756b2ff /drivers/gpu/drm/i915 | |
| parent | drm/i915/gvt: Make DRM_I915_GVT depend on X86 (diff) | |
| download | linux-dev-e87197fbd137c888fd6c871c72fe7e89445dd015.tar.xz linux-dev-e87197fbd137c888fd6c871c72fe7e89445dd015.zip | |
drm/i915/gvt: IS_ERR() vs NULL bug in intel_gvt_update_reg_whitelist()
The shmem_pin_map() function returns NULL, it doesn't return error
pointers.
Fixes: 97ea656521c8 ("drm/i915/gvt: Parse default state to update reg whitelist")
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/Ysftoia2BPUyqVcD@kili
Acked-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Diffstat (limited to 'drivers/gpu/drm/i915')
| -rw-r--r-- | drivers/gpu/drm/i915/gvt/cmd_parser.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c index c4118b808268..11971ee929f8 100644 --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c @@ -3115,9 +3115,9 @@ void intel_gvt_update_reg_whitelist(struct intel_vgpu *vgpu) continue; vaddr = shmem_pin_map(engine->default_state); - if (IS_ERR(vaddr)) { - gvt_err("failed to map %s->default state, err:%zd\n", - engine->name, PTR_ERR(vaddr)); + if (!vaddr) { + gvt_err("failed to map %s->default state\n", + engine->name); return; } |