diff options
| author |   Gustavo A. R. Silva <gustavo@embeddedor.com> | 2018-08-29 10:22:09 -0500 |
|---|---|---|
| committer |   Jiri Kosina <jkosina@suse.cz> | 2018-09-05 10:08:07 +0200 |
| commit | b034ed50a2bb517c4b76e84f7723cb6bf60a4edd (patch) | |
| tree | 1b7d4c13ba8401342f7e122f9ab95f400e707995 /drivers/hid/hid-core.c | |
| parent | HID: core: fix grouping by application (diff) | |
| download | linux-dev-b034ed50a2bb517c4b76e84f7723cb6bf60a4edd.tar.xz linux-dev-b034ed50a2bb517c4b76e84f7723cb6bf60a4edd.zip | |
HID: core: fix NULL pointer dereference
There is a NULL pointer dereference in case memory resources
for *parse* are not successfully allocated.
Fix this by adding a new goto label and make the execution
path jump to it in case vzalloc() fails.
Addresses-Coverity-ID: 1473081 ("Dereference after null check")
Fixes: b2dd9f2e5a8a ("HID: core: fix memory leak on probe")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Stefan Agner <stefan@agner.ch>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid/hid-core.c')
| -rw-r--r-- | drivers/hid/hid-core.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c index 44a465db3f96..44564f61e9cc 100644 --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -1000,7 +1000,7 @@ int hid_open_report(struct hid_device *device) parser = vzalloc(sizeof(struct hid_parser)); if (!parser) { ret = -ENOMEM; - goto err; + goto alloc_err; } parser->device = device; @@ -1049,6 +1049,7 @@ int hid_open_report(struct hid_device *device) hid_err(device, "item fetching failed at offset %d\n", (int)(end - start)); err: kfree(parser->collection_stack); +alloc_err: vfree(parser); hid_close_report(device); return ret; |