diff options
| author |   Rodrigo Rivas Costa <rodrigorivascosta@gmail.com> | 2018-05-22 22:10:06 +0200 |
|---|---|---|
| committer |   Jiri Kosina <jkosina@suse.cz> | 2018-06-20 09:27:23 +0200 |
| commit | 4bff980f920693693d7a529c06a1bd1e7f77603a (patch) | |
| tree | 8591283d9595a9ab3cd2a7c68e767ec9517d3c51 /drivers/hid/intel-ish-hid/ipc/pci-ish.c | |
| parent | HID: google: Add support for whiskers (diff) | |
| download | linux-dev-4bff980f920693693d7a529c06a1bd1e7f77603a.tar.xz linux-dev-4bff980f920693693d7a529c06a1bd1e7f77603a.zip | |
HID: steam: use hid_device.driver_data instead of hid_set_drvdata()
When creating the low-level hidraw device, the reference to steam_device
was stored using hid_set_drvdata(). But this value is not guaranteed to
be kept when set before calling probe. If this pointer is reset, it
crashes when opening the emulated hidraw device.
It looks like hid_set_drvdata() is for users "avobe" this hid_device,
while hid_device.driver_data it for users "below" this one.
In this case, we are creating a virtual hidraw device, so we must use
hid_device.driver_data.
Signed-off-by: Rodrigo Rivas Costa <rodrigorivascosta@gmail.com>
Tested-by: Mariusz Ceier <mceier+kernel@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to '')
0 files changed, 0 insertions, 0 deletions