diff options
| author |   Basavaraj Natikar <Basavaraj.Natikar@amd.com> | 2022-09-27 15:57:26 +0530 |
|---|---|---|
| committer |   Jiri Kosina <jkosina@suse.cz> | 2022-09-30 10:31:18 +0200 |
| commit | 68266bdcceec10ea364e62c63732cd6fe5a256a8 (patch) | |
| tree | 8a99fcef42aa2124869c048d26d140c0ad6f7774 /drivers/hid | |
| parent | HID: amd_sfh: Change dev_err to dev_dbg for additional debug info (diff) | |
| download | linux-dev-68266bdcceec10ea364e62c63732cd6fe5a256a8.tar.xz linux-dev-68266bdcceec10ea364e62c63732cd6fe5a256a8.zip | |
HID: amd_sfh: Handle condition of "no sensors" for SFH1.1
Based on num_hid_devices, each sensor device registers to HID. If
"no sensors" then amd_sfh work initialization and scheduling
doesn’t make sense and return ENODEV to stop driver probe.
Hence add a check for num_hid_devices to handle special
case in the situation of "no sensors" for SFH1.1.
Fixes: 93ce5e0231d7 ("HID: amd_sfh: Implement SFH1.1 functionality")
Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/hid')
| -rw-r--r-- | drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c index d840efb4a2e2..4da2f9f62aba 100644 --- a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c +++ b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c @@ -110,6 +110,8 @@ static int amd_sfh1_1_hid_client_init(struct amd_mp2_dev *privdata) amd_sfh1_1_set_desc_ops(mp2_ops); cl_data->num_hid_devices = amd_sfh_get_sensor_num(privdata, &cl_data->sensor_idx[0]); + if (cl_data->num_hid_devices == 0) + return -ENODEV; INIT_DELAYED_WORK(&cl_data->work, amd_sfh_work); INIT_DELAYED_WORK(&cl_data->work_buffer, amd_sfh_work_buffer); |