aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/infiniband/core/security.c
diff options
context:
space:
mode:
authorDaniel Jurgens <danielj@mellanox.com>2019-02-02 11:09:42 +0200
committerJason Gunthorpe <jgg@mellanox.com>2019-02-08 16:24:44 -0700
commitd60667fc398ed34b3c7456b020481c55c760e503 (patch)
treef8c8fec5b7dd771bd13775352fbaa0d6749c6188 /drivers/infiniband/core/security.c
parentIB/usnic: Fix locking when unregistering (diff)
downloadlinux-dev-d60667fc398ed34b3c7456b020481c55c760e503.tar.xz
linux-dev-d60667fc398ed34b3c7456b020481c55c760e503.zip
IB/core: Unregister notifier before freeing MAD security
If the notifier runs after the security context is freed an access of freed memory can occur. Fixes: 47a2b338fe63 ("IB/core: Enforce security on management datagrams") Signed-off-by: Daniel Jurgens <danielj@mellanox.com> Reviewed-by: Parav Pandit <parav@mellanox.com> Signed-off-by: Leon Romanovsky <leonro@mellanox.com> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Diffstat (limited to '')
-rw-r--r--drivers/infiniband/core/security.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/infiniband/core/security.c b/drivers/infiniband/core/security.c
index 1efadbccf394..402449d4a888 100644
--- a/drivers/infiniband/core/security.c
+++ b/drivers/infiniband/core/security.c
@@ -727,9 +727,10 @@ void ib_mad_agent_security_cleanup(struct ib_mad_agent *agent)
if (!rdma_protocol_ib(agent->device, agent->port_num))
return;
- security_ib_free_security(agent->security);
if (agent->lsm_nb_reg)
unregister_lsm_notifier(&agent->lsm_nb);
+
+ security_ib_free_security(agent->security);
}
int ib_mad_enforce_security(struct ib_mad_agent_private *map, u16 pkey_index)