diff options
| author |   Leon Romanovsky <leonro@mellanox.com> | 2018-02-21 18:12:36 +0200 |
|---|---|---|
| committer |   Doug Ledford <dledford@redhat.com> | 2018-02-22 22:29:36 -0500 |
| commit | f2630ce2fb93eab5f50aa00dac7ae24a3b4ce17f (patch) | |
| tree | db9937395537b32589b2a7c50eae5e1e98e3d0cb /drivers/infiniband/core/uverbs_main.c | |
| parent | RDMA/uverbs: Return not supported error code for unsupported commands (diff) | |
| download | linux-dev-f2630ce2fb93eab5f50aa00dac7ae24a3b4ce17f.tar.xz linux-dev-f2630ce2fb93eab5f50aa00dac7ae24a3b4ce17f.zip | |
RDMA/uverbs: Unify return values of not supported command
The non-existing command is supposed to return -EOPNOTSUPP, but the
current code returns different errors for different flows for the
same failure. This patch unifies those flows.
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to '')
| -rw-r--r-- | drivers/infiniband/core/uverbs_main.c | 16 |
1 files changed, 4 insertions, 12 deletions
diff --git a/drivers/infiniband/core/uverbs_main.c b/drivers/infiniband/core/uverbs_main.c index 8d1547f5dc8e..20797a1c77f3 100644 --- a/drivers/infiniband/core/uverbs_main.c +++ b/drivers/infiniband/core/uverbs_main.c @@ -653,9 +653,11 @@ static bool verify_command_mask(struct ib_device *ib_dev, __u32 command) static bool verify_command_idx(u32 command, bool extended) { if (extended) - return command < ARRAY_SIZE(uverbs_ex_cmd_table); + return command < ARRAY_SIZE(uverbs_ex_cmd_table) && + uverbs_ex_cmd_table[command]; - return command < ARRAY_SIZE(uverbs_cmd_table); + return command < ARRAY_SIZE(uverbs_cmd_table) && + uverbs_cmd_table[command]; } static ssize_t ib_uverbs_write(struct file *filp, const char __user *buf, @@ -730,11 +732,6 @@ static ssize_t ib_uverbs_write(struct file *filp, const char __user *buf, } if (!flags) { - if (!uverbs_cmd_table[command]) { - ret = -EINVAL; - goto out; - } - if (hdr.in_words * 4 != count) { ret = -EINVAL; goto out; @@ -749,11 +746,6 @@ static ssize_t ib_uverbs_write(struct file *filp, const char __user *buf, struct ib_udata uhw; size_t written_count = count; - if (!uverbs_ex_cmd_table[command]) { - ret = -ENOSYS; - goto out; - } - if (!file->ucontext) { ret = -EINVAL; goto out; |