diff options
| author |   Ira Weiny <ira.weiny@intel.com> | 2015-06-25 09:52:50 -0400 |
|---|---|---|
| committer |   Doug Ledford <dledford@redhat.com> | 2015-07-14 13:20:08 -0400 |
| commit | 3b8ab700af0a5c5e59c833f8a88f94b97499f5e5 (patch) | |
| tree | 61c9df6b14a335d7feb9853a629b63645095c180 /drivers/infiniband/hw/mlx4/mad.c | |
| parent | IB/mad: Fix compare between big endian and cpu endian (diff) | |
| download | linux-dev-3b8ab700af0a5c5e59c833f8a88f94b97499f5e5.tar.xz linux-dev-3b8ab700af0a5c5e59c833f8a88f94b97499f5e5.zip | |
IB/mad: Remove improper use of BUG_ON
We recently added BUG_ON's which were inappropriate for a condition which
should never happen. Change these to be WARN_ON_ONCE as a debugging aid.
Fixes: 4cd7c9479aff ('IB/mad: Add support for additional MAD info to/from drivers')
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/infiniband/hw/mlx4/mad.c')
| -rw-r--r-- | drivers/infiniband/hw/mlx4/mad.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/infiniband/hw/mlx4/mad.c index 85a50df2f203..9a810e302f6b 100644 --- a/drivers/infiniband/hw/mlx4/mad.c +++ b/drivers/infiniband/hw/mlx4/mad.c @@ -861,8 +861,9 @@ int mlx4_ib_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num, const struct ib_mad *in_mad = (const struct ib_mad *)in; struct ib_mad *out_mad = (struct ib_mad *)out; - BUG_ON(in_mad_size != sizeof(*in_mad) || - *out_mad_size != sizeof(*out_mad)); + if (WARN_ON_ONCE(in_mad_size != sizeof(*in_mad) || + *out_mad_size != sizeof(*out_mad))) + return IB_MAD_RESULT_FAILURE; switch (rdma_port_get_link_layer(ibdev, port_num)) { case IB_LINK_LAYER_INFINIBAND: |