diff options
| author |   Parav Pandit <parav@mellanox.com> | 2018-04-01 15:08:23 +0300 |
|---|---|---|
| committer |   Jason Gunthorpe <jgg@mellanox.com> | 2018-04-03 21:33:51 -0600 |
| commit | 3e44e0ee0893cbea257e585dbd4c7d2ff00f1a6b (patch) | |
| tree | b51806592482839bfedcb93c808477ea2d71afe9 /drivers/infiniband/hw/qedr/qedr_roce_cm.c | |
| parent | IB/providers: Avoid zero GID check for RoCE (diff) | |
| download | linux-dev-3e44e0ee0893cbea257e585dbd4c7d2ff00f1a6b.tar.xz linux-dev-3e44e0ee0893cbea257e585dbd4c7d2ff00f1a6b.zip | |
IB/providers: Avoid null netdev check for RoCE
Now that IB core GID cache ensures that all RoCE entries have an
associated netdev remove null checks from the provider drivers for
clarity.
Reviewed-by: Mark Bloch <markb@mellanox.com>
Signed-off-by: Parav Pandit <parav@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Diffstat (limited to 'drivers/infiniband/hw/qedr/qedr_roce_cm.c')
| -rw-r--r-- | drivers/infiniband/hw/qedr/qedr_roce_cm.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/drivers/infiniband/hw/qedr/qedr_roce_cm.c b/drivers/infiniband/hw/qedr/qedr_roce_cm.c index eedb937d6fa9..0f14e687bb91 100644 --- a/drivers/infiniband/hw/qedr/qedr_roce_cm.c +++ b/drivers/infiniband/hw/qedr/qedr_roce_cm.c @@ -412,13 +412,11 @@ static inline int qedr_gsi_build_header(struct qedr_dev *dev, return rc; } - if (sgid_attr.ndev) { - vlan_id = rdma_vlan_dev_vlan_id(sgid_attr.ndev); - if (vlan_id < VLAN_CFI_MASK) - has_vlan = true; + vlan_id = rdma_vlan_dev_vlan_id(sgid_attr.ndev); + if (vlan_id < VLAN_CFI_MASK) + has_vlan = true; - dev_put(sgid_attr.ndev); - } + dev_put(sgid_attr.ndev); has_udp = (sgid_attr.gid_type == IB_GID_TYPE_ROCE_UDP_ENCAP); if (!has_udp) { |