diff options
| author |   Bart Van Assche <bart.vanassche@sandisk.com> | 2017-01-10 11:15:47 -0800 |
|---|---|---|
| committer |   Doug Ledford <dledford@redhat.com> | 2017-01-10 16:52:47 -0500 |
| commit | 43553b47c3124e7f4a9f115cff9db513b35a5e0a (patch) | |
| tree | 408a1e2b7e1dfbd97e223df17ce51e58282bcffb /drivers/infiniband/sw/rxe/rxe_resp.c | |
| parent | IB/rxe: Let the compiler check the type of the cleanup functions (diff) | |
| download | linux-dev-43553b47c3124e7f4a9f115cff9db513b35a5e0a.tar.xz linux-dev-43553b47c3124e7f4a9f115cff9db513b35a5e0a.zip | |
IB/rxe: Issue warnings once
It is strongly recommended to report kernel warnings once instead
of every time a condition is hit. Hence change WARN_ON() into
WARN_ON_ONCE() / BUILD_BUG_ON() as appropriate.
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Reviewed-by: Andrew Boyer <andrew.boyer@dell.com>
Cc: Moni Shoua <monis@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to '')
| -rw-r--r-- | drivers/infiniband/sw/rxe/rxe_resp.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/drivers/infiniband/sw/rxe/rxe_resp.c b/drivers/infiniband/sw/rxe/rxe_resp.c index 3435efff8799..6dbd069689fc 100644 --- a/drivers/infiniband/sw/rxe/rxe_resp.c +++ b/drivers/infiniband/sw/rxe/rxe_resp.c @@ -307,7 +307,7 @@ static enum resp_states check_op_valid(struct rxe_qp *qp, break; default: - WARN_ON(1); + WARN_ON_ONCE(1); break; } @@ -495,7 +495,7 @@ static enum resp_states check_rkey(struct rxe_qp *qp, } } - WARN_ON(qp->resp.mr); + WARN_ON_ONCE(qp->resp.mr); qp->resp.mr = mem; return RESPST_EXECUTE; @@ -808,9 +808,10 @@ static enum resp_states execute(struct rxe_qp *qp, struct rxe_pkt_info *pkt) err = process_atomic(qp, pkt); if (err) return err; - } else + } else { /* Unreachable */ - WARN_ON(1); + WARN_ON_ONCE(1); + } /* We successfully processed this new request. */ qp->resp.msn++; @@ -1396,7 +1397,7 @@ int rxe_responder(void *arg) goto exit; default: - WARN_ON(1); + WARN_ON_ONCE(1); } } |