diff options
| author |   Zhu Yanjun <yanjun.zhu@linux.dev> | 2022-08-21 21:16:14 -0400 |
|---|---|---|
| committer |   Leon Romanovsky <leonro@nvidia.com> | 2022-08-31 09:53:13 +0300 |
| commit | 548ce2e66725dcba4e27d1e8ac468d5dd17fd509 (patch) | |
| tree | 56ccc693a0c59912286601387a05f375e1aae34c /drivers/infiniband/sw/rxe | |
| parent | RDMA/rxe: Fix "kernel NULL pointer dereference" error (diff) | |
| download | linux-dev-548ce2e66725dcba4e27d1e8ac468d5dd17fd509.tar.xz linux-dev-548ce2e66725dcba4e27d1e8ac468d5dd17fd509.zip | |
RDMA/rxe: Fix the error caused by qp->sk
When sock_create_kern in the function rxe_qp_init_req fails,
qp->sk is set to NULL.
Then the function rxe_create_qp will call rxe_qp_do_cleanup
to handle allocated resource.
Before handling qp->sk, this variable should be checked.
Fixes: 8700e3e7c485 ("Soft RoCE driver")
Link: https://lore.kernel.org/r/20220822011615.805603-3-yanjun.zhu@linux.dev
Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
Reviewed-by: Bob Pearson <rpearsonhpe@gmail.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Diffstat (limited to 'drivers/infiniband/sw/rxe')
| -rw-r--r-- | drivers/infiniband/sw/rxe/rxe_qp.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/infiniband/sw/rxe/rxe_qp.c b/drivers/infiniband/sw/rxe/rxe_qp.c index fda03f9f03ed..d776dfda43b1 100644 --- a/drivers/infiniband/sw/rxe/rxe_qp.c +++ b/drivers/infiniband/sw/rxe/rxe_qp.c @@ -835,8 +835,10 @@ static void rxe_qp_do_cleanup(struct work_struct *work) free_rd_atomic_resources(qp); - kernel_sock_shutdown(qp->sk, SHUT_RDWR); - sock_release(qp->sk); + if (qp->sk) { + kernel_sock_shutdown(qp->sk, SHUT_RDWR); + sock_release(qp->sk); + } } /* called when the last reference to the qp is dropped */ |