path: root/drivers/infiniband
diff options
authorNathan Chancellor <natechancellor@gmail.com>2020-01-16 15:26:58 -0700
committerJason Gunthorpe <jgg@mellanox.com>2020-01-25 15:33:53 -0400
commit79ba4f9310673a8870fda5a062a558923fa65c93 (patch)
tree6fb568a025f62b4df444cea49362839402671eef /drivers/infiniband
parentRDMA/cm: Remove CM message structs (diff)
IB/hfi1: Fix logical condition in msix_request_irq
Clang warns: drivers/infiniband/hw/hfi1/msix.c:136:22: warning: overlapping comparisons always evaluate to false [-Wtautological-overlap-compare] if (type < IRQ_SDMA && type >= IRQ_OTHER) ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~ 1 warning generated. It is impossible for something to be less than 0 (IRQ_SDMA) and greater than or equal to 3 (IRQ_OTHER) at the same time. A logical OR should have been used to keep the same logic as before. Link: https://lore.kernel.org/r/20200116222658.5285-1-natechancellor@gmail.com Link: https://github.com/ClangBuiltLinux/linux/issues/841 Fixes: 13d2a8384bd9 ("IB/hfi1: Decouple IRQ name from type") Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Acked-by: Dennis Dalessandro <dennis.dalessandro@intel.com> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Diffstat (limited to 'drivers/infiniband')
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/hfi1/msix.c b/drivers/infiniband/hw/hfi1/msix.c
index 4a620cf80588..db82db497b2c 100644
--- a/drivers/infiniband/hw/hfi1/msix.c
+++ b/drivers/infiniband/hw/hfi1/msix.c
@@ -133,7 +133,7 @@ static int msix_request_irq(struct hfi1_devdata *dd, void *arg,
if (nr == dd->msix_info.max_requested)
return -ENOSPC;
- if (type < IRQ_SDMA && type >= IRQ_OTHER)
+ if (type < IRQ_SDMA || type >= IRQ_OTHER)
return -EINVAL;
irq = pci_irq_vector(dd->pcidev, nr);