diff options
| author |   Mark Bloch <markb@mellanox.com> | 2016-05-06 22:45:24 +0300 |
|---|---|---|
| committer |   Doug Ledford <dledford@redhat.com> | 2016-05-13 19:40:01 -0400 |
| commit | 5ed935e861a4cbf2158ad3386d6d26edd60d2658 (patch) | |
| tree | 41d4437ccd146a6a585982c9cd1f323ef2fb7df0 /drivers/infiniband | |
| parent | RDMA/nes: replace custom print_hex_dump() (diff) | |
| download | linux-dev-5ed935e861a4cbf2158ad3386d6d26edd60d2658.tar.xz linux-dev-5ed935e861a4cbf2158ad3386d6d26edd60d2658.zip | |
IB/IWPM: Fix a potential skb leak
In case ibnl_put_msg fails in send_nlmsg_done,
the function returns with -ENOMEM without freeing.
This patch fixes this behavior.
Fixes: 30dc5e63d6a5 ("RDMA/core: Add support for iWARP Port Mapper user space service")
Signed-off-by: Mark Bloch <markb@mellanox.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Reviewed-by: Steve Wise <swise@opengridcomputing.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/infiniband')
| -rw-r--r-- | drivers/infiniband/core/iwpm_util.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/infiniband/core/iwpm_util.c b/drivers/infiniband/core/iwpm_util.c index 9b2bf2fb2b00..b65e06c560d7 100644 --- a/drivers/infiniband/core/iwpm_util.c +++ b/drivers/infiniband/core/iwpm_util.c @@ -634,6 +634,7 @@ static int send_nlmsg_done(struct sk_buff *skb, u8 nl_client, int iwpm_pid) if (!(ibnl_put_msg(skb, &nlh, 0, 0, nl_client, RDMA_NL_IWPM_MAPINFO, NLM_F_MULTI))) { pr_warn("%s Unable to put NLMSG_DONE\n", __func__); + dev_kfree_skb(skb); return -ENOMEM; } nlh->nlmsg_type = NLMSG_DONE; |