diff options
| author |   Jason Gunthorpe <jgg@mellanox.com> | 2020-01-15 20:20:44 +0000 |
|---|---|---|
| committer | Jason Gunthorpe <jgg@mellanox.com> | 2020-01-25 14:48:33 -0400 |
| commit | 6b3712c0246ca7b2b8fa05eab2362cf267410f7e (patch) | |
| tree | 92e6c4176876b55dad68d9200a2ec2f4838db2c0 /drivers/infiniband | |
| parent | Merge tag 'rds-odp-for-5.5' into rdma.git for-next (diff) | |
| download | linux-dev-6b3712c0246ca7b2b8fa05eab2362cf267410f7e.tar.xz linux-dev-6b3712c0246ca7b2b8fa05eab2362cf267410f7e.zip | |
RDMA/core: Ensure that rdma_user_mmap_entry_remove() is a fence
The set of entry->driver_removed is missing locking, protect it with
xa_lock() which is held by the only reader.
Otherwise readers may continue to see driver_removed = false after
rdma_user_mmap_entry_remove() returns and may continue to try and
establish new mmaps.
Fixes: 3411f9f01b76 ("RDMA/core: Create mmap database and cookie helper functions")
Link: https://lore.kernel.org/r/20200115202041.GA17199@ziepe.ca
Reviewed-by: Gal Pressman <galpress@amazon.com>
Acked-by: Michal Kalderon <michal.kalderon@marvell.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Diffstat (limited to 'drivers/infiniband')
| -rw-r--r-- | drivers/infiniband/core/ib_core_uverbs.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/infiniband/core/ib_core_uverbs.c b/drivers/infiniband/core/ib_core_uverbs.c index b7cb59844ece..b51bd7087a88 100644 --- a/drivers/infiniband/core/ib_core_uverbs.c +++ b/drivers/infiniband/core/ib_core_uverbs.c @@ -232,7 +232,9 @@ void rdma_user_mmap_entry_remove(struct rdma_user_mmap_entry *entry) if (!entry) return; + xa_lock(&entry->ucontext->mmap_xa); entry->driver_removed = true; + xa_unlock(&entry->ucontext->mmap_xa); kref_put(&entry->ref, rdma_user_mmap_entry_free); } EXPORT_SYMBOL(rdma_user_mmap_entry_remove); |