diff options
| author |   Majd Dibbiny <majd@mellanox.com> | 2016-10-27 16:36:39 +0300 |
|---|---|---|
| committer |   Doug Ledford <dledford@redhat.com> | 2016-11-16 20:03:44 -0500 |
| commit | 90be7c8ab72853ff9fc407f01518a898df1f3045 (patch) | |
| tree | e1c741e4146a24b3601cb87280cbf3b8c3b8c3fd /drivers/infiniband | |
| parent | IB/core: Avoid unsigned int overflow in sg_alloc_table (diff) | |
| download | linux-dev-90be7c8ab72853ff9fc407f01518a898df1f3045.tar.xz linux-dev-90be7c8ab72853ff9fc407f01518a898df1f3045.zip | |
IB/mlx5: Fix memory leak in query device
We need to free dev->port when we fail to enable RoCE or
initialize node data.
Fixes: 0837e86a7a34 ('IB/mlx5: Add per port counters')
Signed-off-by: Majd Dibbiny <majd@mellanox.com>
Signed-off-by: Maor Gottlieb <maorg@mellanox.com>
Reviewed-by: Mark Bloch <markb@mellanox.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to '')
| -rw-r--r-- | drivers/infiniband/hw/mlx5/main.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c index 22174774dbb8..bb61487861cc 100644 --- a/drivers/infiniband/hw/mlx5/main.c +++ b/drivers/infiniband/hw/mlx5/main.c @@ -3115,7 +3115,7 @@ static void *mlx5_ib_add(struct mlx5_core_dev *mdev) } err = init_node_data(dev); if (err) - goto err_dealloc; + goto err_free_port; mutex_init(&dev->flow_db.lock); mutex_init(&dev->cap_mask_mutex); @@ -3125,7 +3125,7 @@ static void *mlx5_ib_add(struct mlx5_core_dev *mdev) if (ll == IB_LINK_LAYER_ETHERNET) { err = mlx5_enable_roce(dev); if (err) - goto err_dealloc; + goto err_free_port; } err = create_dev_resources(&dev->devr); |