aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/infiniband
diff options
context:
space:
mode:
authorBart Van Assche <bart.vanassche@sandisk.com>2017-02-14 10:56:34 -0800
committerDoug Ledford <dledford@redhat.com>2017-02-19 09:51:54 -0500
commitb02c15360b17dde352fbf4003e20dabcd3ae9157 (patch)
tree1c75527b354d38f3be5dfef87f75f5188976a1a3 /drivers/infiniband
parentIB/srp: Make a diagnostic message more informative (diff)
downloadlinux-dev-b02c15360b17dde352fbf4003e20dabcd3ae9157.tar.xz
linux-dev-b02c15360b17dde352fbf4003e20dabcd3ae9157.zip
IB/srp: Improve an error path
Avoid that the following message is printed if login fails: scsi host0: ib_srp: Sending CM DREQ failed Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com> Cc: Israel Rukshin <israelr@mellanox.com> Cc: Max Gurtovoy <maxg@mellanox.com> Cc: Laurence Oberman <loberman@redhat.com> Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/infiniband')
-rw-r--r--drivers/infiniband/ulp/srp/ib_srp.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
index 33dd0920c248..e8225cc8b938 100644
--- a/drivers/infiniband/ulp/srp/ib_srp.c
+++ b/drivers/infiniband/ulp/srp/ib_srp.c
@@ -3440,7 +3440,7 @@ static ssize_t srp_create_target(struct device *dev,
target->ch_count,
ch->target->orig_dgid.raw);
if (node_idx == 0 && cpu_idx == 0) {
- goto err_disconnect;
+ goto free_ch;
} else {
srp_free_ch_ib(target, ch);
srp_free_req_data(target, ch);
@@ -3487,6 +3487,7 @@ put:
err_disconnect:
srp_disconnect_target(target);
+free_ch:
for (i = 0; i < target->ch_count; i++) {
ch = &target->ch[i];
srp_free_ch_ib(target, ch);