diff options
| author |   Parav Pandit <parav@mellanox.com> | 2018-09-21 09:18:24 -0500 |
|---|---|---|
| committer |   Jason Gunthorpe <jgg@mellanox.com> | 2018-10-03 20:47:41 -0600 |
| commit | fe33507ec38a8b2e8b782b83669943b7a5fefd4c (patch) | |
| tree | 500313048e9b3ecbdbd25732faba0e675678e0fc /drivers/infiniband | |
| parent | IB/{hfi1, qib, rdmavt}: Move ruc_loopback to rdmavt (diff) | |
| download | linux-dev-fe33507ec38a8b2e8b782b83669943b7a5fefd4c.tar.xz linux-dev-fe33507ec38a8b2e8b782b83669943b7a5fefd4c.zip | |
RDMA/core: Check error status of rdma_find_ndev_for_src_ip_rcu
rdma_find_ndev_for_src_ip_rcu() returns either valid netdev pointer or
ERR_PTR(). Instead of checking for NULL, check for error.
Fixes: caf1e3ae9fa6 ("RDMA/core Introduce and use rdma_find_ndev_for_src_ip_rcu")
Reported-by: syzbot+20c32fa6ff84a2d28c36@syzkaller.appspotmail.com
Signed-off-by: Parav Pandit <parav@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Diffstat (limited to 'drivers/infiniband')
| -rw-r--r-- | drivers/infiniband/core/addr.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c index 1400a9d0d56d..07e0ffe74a8a 100644 --- a/drivers/infiniband/core/addr.c +++ b/drivers/infiniband/core/addr.c @@ -513,7 +513,7 @@ static int rdma_set_src_addr_rcu(struct rdma_dev_addr *dev_addr, * loopback IP address. */ ndev = rdma_find_ndev_for_src_ip_rcu(dev_net(ndev), dst_in); - if (!ndev) + if (IS_ERR(ndev)) return -ENODEV; } |