aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/input/mouse/synaptics.c
diff options
context:
space:
mode:
authorGustavo A. R. Silva <gustavo@embeddedor.com>2020-02-13 16:57:00 -0800
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2020-02-13 17:09:47 -0800
commita1b9b65edfd8f195dafaebf68f7d321eb9b3ab82 (patch)
tree34fe042c28be17515b9c279be642462cdc29067b /drivers/input/mouse/synaptics.c
parentInput: goldfish_events - replace zero-length array with flexible-array member (diff)
downloadlinux-dev-a1b9b65edfd8f195dafaebf68f7d321eb9b3ab82.tar.xz
linux-dev-a1b9b65edfd8f195dafaebf68f7d321eb9b3ab82.zip
Input: gpio_keys - replace zero-length array with flexible-array member
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By making use of the mechanism above, we will get a compiler warning in case the flexible array does not occur last in the structure, which will help us prevent some kind of undefined behavior bugs from being inadvertently introduced[3] to the codebase from now on. Also, notice that, dynamic memory allocations won't be affected by this change: "Flexible array members have incomplete type, and so the sizeof operator may not be applied. As a quirk of the original implementation of zero-length arrays, sizeof evaluates to zero."[1] This issue was found with the help of Coccinelle. [1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html [2] https://github.com/KSPP/linux/issues/21 [3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Link: https://lore.kernel.org/r/20200213002600.GA31916@embeddedor.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input/mouse/synaptics.c')
0 files changed, 0 insertions, 0 deletions