diff options
| author |   Paul Cercueil <paul@crapouillou.net> | 2015-05-06 16:52:13 -0700 |
|---|---|---|
| committer |   Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2015-05-06 16:54:25 -0700 |
| commit | 5f6f117c12a3fb25ecadd6dfcdd1a3a431269ade (patch) | |
| tree | 241808c71b7ccde22694dd564c06a7fc4970b79f /drivers/input/touchscreen/goodix.c | |
| parent | Input: adp5589-keys - fix event count mask (diff) | |
| download | linux-dev-5f6f117c12a3fb25ecadd6dfcdd1a3a431269ade.tar.xz linux-dev-5f6f117c12a3fb25ecadd6dfcdd1a3a431269ade.zip | |
Input: goodix - check the 'buffer status' bit before reading data
The MSB of the first byte read via I2C at the coordinates address
indicates whether the data is valid or ready (called "buffer status" in
the datasheets) when an interrupt is raised. Previously, this bit was
ignored, which resulted in a lot of incorrect detections of "finger
removed" events.
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Acked-by: Bastien Nocera <hadess@hadess.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to '')
| -rw-r--r-- | drivers/input/touchscreen/goodix.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c index 3af16984d57c..0d93b1e5e28e 100644 --- a/drivers/input/touchscreen/goodix.c +++ b/drivers/input/touchscreen/goodix.c @@ -101,6 +101,9 @@ static int goodix_ts_read_input_report(struct goodix_ts_data *ts, u8 *data) return error; } + if (!(data[0] & 0x80)) + return -EAGAIN; + touch_num = data[0] & 0x0f; if (touch_num > ts->max_touch_num) return -EPROTO; |