diff options
| author |   Joerg Roedel <jroedel@suse.de> | 2019-09-25 15:22:55 +0200 |
|---|---|---|
| committer | Joerg Roedel <jroedel@suse.de> | 2019-09-28 14:43:36 +0200 |
| commit | f15d9a992f901d4f22db868adf800844d1cac9f2 (patch) | |
| tree | 2c3bb88ca50ec64df785f1343708c1c2b243a19e /drivers/iommu/amd_iommu_types.h | |
| parent | iommu/amd: Wait for completion of IOTLB flush in attach_device (diff) | |
| download | linux-dev-f15d9a992f901d4f22db868adf800844d1cac9f2.tar.xz linux-dev-f15d9a992f901d4f22db868adf800844d1cac9f2.zip | |
iommu/amd: Remove domain->updated
This struct member was used to track whether a domain
change requires updates to the device-table and IOMMU cache
flushes. The problem is, that access to this field is racy
since locking in the common mapping code-paths has been
eliminated.
Move the updated field to the stack to get rid of all
potential races and remove the field from the struct.
Fixes: 92d420ec028d ("iommu/amd: Relax locking in dma_ops path")
Reviewed-by: Filippo Sironi <sironi@amazon.de>
Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
Diffstat (limited to '')
| -rw-r--r-- | drivers/iommu/amd_iommu_types.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/iommu/amd_iommu_types.h b/drivers/iommu/amd_iommu_types.h index 9ac229e92b07..0186501ab971 100644 --- a/drivers/iommu/amd_iommu_types.h +++ b/drivers/iommu/amd_iommu_types.h @@ -475,7 +475,6 @@ struct protection_domain { int glx; /* Number of levels for GCR3 table */ u64 *gcr3_tbl; /* Guest CR3 table */ unsigned long flags; /* flags to find out type of domain */ - bool updated; /* complete domain flush required */ unsigned dev_cnt; /* devices assigned to this domain */ unsigned dev_iommu[MAX_IOMMUS]; /* per-IOMMU reference count */ }; |