diff options
| author |   Coly Li <colyli@suse.de> | 2021-01-04 15:41:20 +0800 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2021-01-09 09:21:03 -0700 |
| commit | 1dfc0686c29a9bbd3a446a29f9ccde3dec3bc75a (patch) | |
| tree | e05ae84eb520f5c17721c61690aa9f0e2a92fe72 /drivers/md/bcache/super.c | |
| parent | bcache: fix typo from SUUP to SUPP in features.h (diff) | |
| download | linux-dev-1dfc0686c29a9bbd3a446a29f9ccde3dec3bc75a.tar.xz linux-dev-1dfc0686c29a9bbd3a446a29f9ccde3dec3bc75a.zip | |
bcache: check unsupported feature sets for bcache register
This patch adds the check for features which is incompatible for
current supported feature sets.
Now if the bcache device created by bcache-tools has features that
current kernel doesn't support, read_super() will fail with error
messoage. E.g. if an unsupported incompatible feature detected,
bcache register will fail with dmesg "bcache: register_bcache() error :
Unsupported incompatible feature found".
Fixes: d721a43ff69c ("bcache: increase super block version for cache device and backing device")
Fixes: ffa470327572 ("bcache: add bucket_size_hi into struct cache_sb_disk for large bucket")
Signed-off-by: Coly Li <colyli@suse.de>
Cc: stable@vger.kernel.org # 5.9+
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to '')
| -rw-r--r-- | drivers/md/bcache/super.c | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 6aa23a6fb394..f4674a3298af 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -228,6 +228,20 @@ static const char *read_super(struct cache_sb *sb, struct block_device *bdev, sb->feature_compat = le64_to_cpu(s->feature_compat); sb->feature_incompat = le64_to_cpu(s->feature_incompat); sb->feature_ro_compat = le64_to_cpu(s->feature_ro_compat); + + /* Check incompatible features */ + err = "Unsupported compatible feature found"; + if (bch_has_unknown_compat_features(sb)) + goto err; + + err = "Unsupported read-only compatible feature found"; + if (bch_has_unknown_ro_compat_features(sb)) + goto err; + + err = "Unsupported incompatible feature found"; + if (bch_has_unknown_incompat_features(sb)) + goto err; + err = read_super_common(sb, bdev, s); if (err) goto err; |