diff options
| author |   majianpeng <majianpeng@gmail.com> | 2012-11-08 08:56:27 +0800 |
|---|---|---|
| committer |   NeilBrown <neilb@suse.de> | 2012-11-20 10:27:17 +1100 |
| commit | 35f9ac2dcec8f79d7059ce174fd7b7ee3290d620 (patch) | |
| tree | 0192c0d2874221bf8672e278c86fd0239cb32b08 /drivers/md/md.c | |
| parent | md: Reassigned the parameters if read_seqretry returned true in func md_is_badblock. (diff) | |
| download | linux-dev-35f9ac2dcec8f79d7059ce174fd7b7ee3290d620.tar.xz linux-dev-35f9ac2dcec8f79d7059ce174fd7b7ee3290d620.zip | |
md: Avoid write invalid address if read_seqretry returned true.
If read_seqretry returned true and bbp was changed, it will write
invalid address which can cause some serious problem.
This bug was introduced by commit v3.0-rc7-130-g2699b67.
So fix is suitable for 3.0.y thru 3.6.y.
Reported-by: zhuwenfeng@kedacom.com
Tested-by: zhuwenfeng@kedacom.com
Cc: stable@vger.kernel.org
Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to '')
| -rw-r--r-- | drivers/md/md.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c index 14db6abb2c42..4c7d880a60a4 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -1817,10 +1817,10 @@ retry: memset(bbp, 0xff, PAGE_SIZE); for (i = 0 ; i < bb->count ; i++) { - u64 internal_bb = *p++; + u64 internal_bb = p[i]; u64 store_bb = ((BB_OFFSET(internal_bb) << 10) | BB_LEN(internal_bb)); - *bbp++ = cpu_to_le64(store_bb); + bbp[i] = cpu_to_le64(store_bb); } bb->changed = 0; if (read_seqretry(&bb->lock, seq)) |