diff options
| author |   Mike Snitzer <snitzer@redhat.com> | 2015-10-22 10:56:40 -0400 |
|---|---|---|
| committer | Mike Snitzer <snitzer@redhat.com> | 2015-10-23 14:02:55 -0400 |
| commit | 4dcb8b57df3593dcb20481d9d6cf79d1dc1534be (patch) | |
| tree | 7dae30ad56516dc9b137f25484cc2ef91a7ff3fa /drivers/md/persistent-data/dm-btree.c | |
| parent | dm btree remove: fix a bug when rebalancing nodes after removal (diff) | |
| download | linux-dev-4dcb8b57df3593dcb20481d9d6cf79d1dc1534be.tar.xz linux-dev-4dcb8b57df3593dcb20481d9d6cf79d1dc1534be.zip | |
dm btree: fix leak of bufio-backed block in btree_split_beneath error path
btree_split_beneath()'s error path had an outstanding FIXME that speaks
directly to the potential for _not_ cleaning up a previously allocated
bufio-backed block.
Fix this by releasing the previously allocated bufio block using
unlock_block().
Reported-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Acked-by: Joe Thornber <thornber@redhat.com>
Cc: stable@vger.kernel.org
Diffstat (limited to '')
| -rw-r--r-- | drivers/md/persistent-data/dm-btree.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/md/persistent-data/dm-btree.c b/drivers/md/persistent-data/dm-btree.c index b6cec258cc21..0e09aef43998 100644 --- a/drivers/md/persistent-data/dm-btree.c +++ b/drivers/md/persistent-data/dm-btree.c @@ -523,7 +523,7 @@ static int btree_split_beneath(struct shadow_spine *s, uint64_t key) r = new_block(s->info, &right); if (r < 0) { - /* FIXME: put left */ + unlock_block(s->info, left); return r; } |