diff options
| author |   Luis Chamberlain <mcgrof@kernel.org> | 2021-10-15 16:30:22 -0700 |
|---|---|---|
| committer |   Mike Snitzer <snitzer@redhat.com> | 2021-11-01 13:28:44 -0400 |
| commit | 089975379d52e7b99f2baf76e0d45bf2176be2bf (patch) | |
| tree | 20f5c978152ed37f17cb79e519d926a9ab2d4fa2 /drivers/md | |
| parent | dm: Remove redundant flush_workqueue() calls (diff) | |
| download | linux-dev-089975379d52e7b99f2baf76e0d45bf2176be2bf.tar.xz linux-dev-089975379d52e7b99f2baf76e0d45bf2176be2bf.zip | |
dm: add add_disk() error handling
We never checked for errors on add_disk() as this function returned
void. Now that this is fixed, use the shiny new error handling.
There are two calls to dm_setup_md_queue() which can fail then, one on
dm_early_create() and we can easily see that the error path there
calls dm_destroy in the error path. The other use case is on the ioctl
table_load case. If that fails userspace needs to call the
DM_DEV_REMOVE_CMD to cleanup the state - similar to any other
failure.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/dm.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/md/dm.c b/drivers/md/dm.c index 76d9da49fda7..b966634cafd4 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@ -2086,7 +2086,9 @@ int dm_setup_md_queue(struct mapped_device *md, struct dm_table *t) if (r) return r; - add_disk(md->disk); + r = add_disk(md->disk); + if (r) + return r; r = dm_sysfs_init(md); if (r) { |