diff options
| author |   David Sloan <david.sloan@eideticom.com> | 2022-08-11 11:14:13 -0600 |
|---|---|---|
| committer |   Song Liu <song@kernel.org> | 2022-08-24 10:26:35 -0700 |
| commit | 5e8daf906f890560df430d30617c692a794acb73 (patch) | |
| tree | c09583de050d1ef94630f971b03a7fe49b611af0 /drivers/md | |
| parent | md/raid10: Fix the data type of an r10_sync_page_io() argument (diff) | |
| download | linux-dev-5e8daf906f890560df430d30617c692a794acb73.tar.xz linux-dev-5e8daf906f890560df430d30617c692a794acb73.zip | |
md: Flush workqueue md_rdev_misc_wq in md_alloc()
A race condition still exists when removing and re-creating md devices
in test cases. However, it is only seen on some setups.
The race condition was tracked down to a reference still being held
to the kobject by the rdev in the md_rdev_misc_wq which will be released
in rdev_delayed_delete().
md_alloc() waits for previous deletions by waiting on the md_misc_wq,
but the md_rdev_misc_wq may still be holding a reference to a recently
removed device.
To fix this, also flush the md_rdev_misc_wq in md_alloc().
Signed-off-by: David Sloan <david.sloan@eideticom.com>
[logang@deltatee.com: rewrote commit message]
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Song Liu <song@kernel.org>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/md.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c index afaf36b2f6ab..71d221601bf8 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -5620,6 +5620,7 @@ struct mddev *md_alloc(dev_t dev, char *name) * removed (mddev_delayed_delete). */ flush_workqueue(md_misc_wq); + flush_workqueue(md_rdev_misc_wq); mutex_lock(&disks_mutex); mddev = mddev_alloc(dev); |