diff options
| author |   Coly Li <colyli@suse.de> | 2020-01-24 01:01:30 +0800 |
|---|---|---|
| committer |   Jens Axboe <axboe@kernel.dk> | 2020-01-23 11:40:01 -0700 |
| commit | ae3cd299919af6eb670d5af0bc9d7ba14086bd8e (patch) | |
| tree | c7d1875cd935ab39b4ad62a2c819838bf013f8b6 /drivers/md | |
| parent | bcache: properly initialize 'path' and 'err' in register_bcache() (diff) | |
| download | linux-dev-ae3cd299919af6eb670d5af0bc9d7ba14086bd8e.tar.xz linux-dev-ae3cd299919af6eb670d5af0bc9d7ba14086bd8e.zip | |
bcache: fix use-after-free in register_bcache()
The patch "bcache: rework error unwinding in register_bcache" introduces
a use-after-free regression in register_bcache(). Here are current code,
2510 out_free_path:
2511 kfree(path);
2512 out_module_put:
2513 module_put(THIS_MODULE);
2514 out:
2515 pr_info("error %s: %s", path, err);
2516 return ret;
If some error happens and the above code path is executed, at line 2511
path is released, but referenced at line 2515. Then KASAN reports a use-
after-free error message.
This patch changes line 2515 in the following way to fix the problem,
2515 pr_info("error %s: %s", path?path:"", err);
Signed-off-by: Coly Li <colyli@suse.de>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/md')
| -rw-r--r-- | drivers/md/bcache/super.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index ee7c87f38d0d..fad9c6cbee5e 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -2477,10 +2477,11 @@ out_free_sb: kfree(sb); out_free_path: kfree(path); + path = NULL; out_module_put: module_put(THIS_MODULE); out: - pr_info("error %s: %s", path, err); + pr_info("error %s: %s", path?path:"", err); return ret; } |