diff options
| author |   Hans Verkuil <hverkuil-cisco@xs4all.nl> | 2018-11-19 10:33:44 -0500 |
|---|---|---|
| committer |   Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | 2018-11-23 06:42:15 -0500 |
| commit | 5e99456c20f712dcc13d9f6ca4278937d5367355 (patch) | |
| tree | b7df04e1962020806d52a64b14989139cb542110 /drivers/media/common/videobuf2/videobuf2-v4l2.c | |
| parent | media: vb2: Allow reqbufs(0) with "in use" MMAP buffers (diff) | |
| download | linux-dev-5e99456c20f712dcc13d9f6ca4278937d5367355.tar.xz linux-dev-5e99456c20f712dcc13d9f6ca4278937d5367355.zip | |
media: videobuf2-v4l2: drop WARN_ON in vb2_warn_zero_bytesused()
Userspace shouldn't set bytesused to 0 for output buffers.
vb2_warn_zero_bytesused() warns about this (only once!), but it also
calls WARN_ON(1), which is confusing since it is not immediately clear
that it warns about a 0 value for bytesused.
Just drop the WARN_ON as it serves no purpose.
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Acked-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/media/common/videobuf2/videobuf2-v4l2.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/media/common/videobuf2/videobuf2-v4l2.c b/drivers/media/common/videobuf2/videobuf2-v4l2.c index f02d452ceeb9..1244c246d0c4 100644 --- a/drivers/media/common/videobuf2/videobuf2-v4l2.c +++ b/drivers/media/common/videobuf2/videobuf2-v4l2.c @@ -158,7 +158,6 @@ static void vb2_warn_zero_bytesused(struct vb2_buffer *vb) return; check_once = true; - WARN_ON(1); pr_warn("use of bytesused == 0 is deprecated and will be removed in the future,\n"); if (vb->vb2_queue->allow_zero_bytesused) |