diff options
| author |   NeilBrown <neil@brown.name> | 2019-05-04 20:24:56 +1000 |
|---|---|---|
| committer |   Ulf Hansson <ulf.hansson@linaro.org> | 2019-05-06 12:33:03 +0200 |
| commit | 42edb0d5ac3ee1ac247e3f56be4263f14ed99f11 (patch) | |
| tree | 9e70ab0b13aedd0a8ed968b5655040dbc05593ea /drivers/mmc/host/mtk-sd.c | |
| parent | mmc: core: Fix tag set memory leak (diff) | |
| download | linux-dev-42edb0d5ac3ee1ac247e3f56be4263f14ed99f11.tar.xz linux-dev-42edb0d5ac3ee1ac247e3f56be4263f14ed99f11.zip | |
mmc: mtk-sd: don't hard-code interrupt trigger type
When using devicetree for configuration, interrupt trigger type
should be described in the dts file, not hard-coded in the C code.
The mtk-sd silicon in the mt7621 soc uses an active-high interrupt
and so cannot be used with the current code.
So replace IRQF_TRIGGER_LOW with IRQF_TRIGGER_NONE.
Also IRQF_ONESHOT is not needed - it is used for threaded interrupt
handlers, and this driver does not used a threaded interrupt handler.
So remove that setting.
Signed-off-by: NeilBrown <neil@brown.name>
Reviewed-by: Chaotian Jing <chaotian.jing@mediatek.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/mmc/host/mtk-sd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index 0798f0ba6d34..469d4a717175 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -2240,7 +2240,7 @@ static int msdc_drv_probe(struct platform_device *pdev) msdc_init_hw(host); ret = devm_request_irq(&pdev->dev, host->irq, msdc_irq, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, pdev->name, host); + IRQF_TRIGGER_NONE, pdev->name, host); if (ret) goto release; |