diff options
| author |   Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2021-11-08 10:31:50 +0100 |
|---|---|---|
| committer |   Miquel Raynal <miquel.raynal@bootlin.com> | 2021-12-03 14:27:19 +0100 |
| commit | 367cefbaed42eac9e1da5cc88f3b9220afc2db4d (patch) | |
| tree | 422db7f8320de73e0bc9f9d61886664521a13560 /drivers/mtd/devices/mchp23k256.c | |
| parent | mtd: dataflash: Warn about failure to unregister mtd device (diff) | |
| download | linux-dev-367cefbaed42eac9e1da5cc88f3b9220afc2db4d.tar.xz linux-dev-367cefbaed42eac9e1da5cc88f3b9220afc2db4d.zip | |
mtd: mchp23k256: Warn about failure to unregister mtd device
mtd_device_unregister() shouldn't fail. Wail loudly if it does anyhow.
This matches how other drivers (e.g. nand/raw/nandsim.c) use
mtd_device_unregister().
By returning 0 in the spi remove callback a generic error message by the
spi framework (and nothing else) is suppressed.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20211108093153.63792-2-u.kleine-koenig@pengutronix.de
Diffstat (limited to '')
| -rw-r--r-- | drivers/mtd/devices/mchp23k256.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/mtd/devices/mchp23k256.c b/drivers/mtd/devices/mchp23k256.c index 77c872fd3d83..a8b31bddf14b 100644 --- a/drivers/mtd/devices/mchp23k256.c +++ b/drivers/mtd/devices/mchp23k256.c @@ -213,7 +213,9 @@ static int mchp23k256_remove(struct spi_device *spi) { struct mchp23k256_flash *flash = spi_get_drvdata(spi); - return mtd_device_unregister(&flash->mtd); + WARN_ON(mtd_device_unregister(&flash->mtd)); + + return 0; } static const struct of_device_id mchp23k256_of_table[] = { |