diff options
| author |   Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2021-11-08 10:31:49 +0100 |
|---|---|---|
| committer |   Miquel Raynal <miquel.raynal@bootlin.com> | 2021-12-03 14:27:19 +0100 |
| commit | 4fea96afff3037ae8b353f08457b3e006ad8f875 (patch) | |
| tree | a7c3190758402eac1c30dc07a918f32c4d9f9531 /drivers/mtd/devices/mtd_dataflash.c | |
| parent | mtd: core: provide unique name for nvmem device (diff) | |
| download | linux-dev-4fea96afff3037ae8b353f08457b3e006ad8f875.tar.xz linux-dev-4fea96afff3037ae8b353f08457b3e006ad8f875.zip | |
mtd: dataflash: Warn about failure to unregister mtd device
mtd_device_unregister() shouldn't fail. Wail loudly if it does anyhow.
This matches how other drivers (e.g. nand/raw/nandsim.c) use
mtd_device_unregister().
By returning 0 in the spi remove callback a generic error message by the
spi framework (and nothing else) is suppressed.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20211108093153.63792-1-u.kleine-koenig@pengutronix.de
Diffstat (limited to '')
| -rw-r--r-- | drivers/mtd/devices/mtd_dataflash.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/mtd/devices/mtd_dataflash.c b/drivers/mtd/devices/mtd_dataflash.c index 9802e265fca8..293cab758299 100644 --- a/drivers/mtd/devices/mtd_dataflash.c +++ b/drivers/mtd/devices/mtd_dataflash.c @@ -912,14 +912,14 @@ static int dataflash_probe(struct spi_device *spi) static int dataflash_remove(struct spi_device *spi) { struct dataflash *flash = spi_get_drvdata(spi); - int status; dev_dbg(&spi->dev, "remove\n"); - status = mtd_device_unregister(&flash->mtd); - if (status == 0) - kfree(flash); - return status; + WARN_ON(mtd_device_unregister(&flash->mtd)); + + kfree(flash); + + return 0; } static struct spi_driver dataflash_driver = { |