diff options
| author |   Fabio Estevam <fabio.estevam@freescale.com> | 2013-11-07 22:32:38 -0200 |
|---|---|---|
| committer |   Brian Norris <computersforpeace@gmail.com> | 2014-01-03 11:22:08 -0800 |
| commit | 554cbc509f4ef95b0f06d04d94f0b0c2019dee26 (patch) | |
| tree | e4fc20ef992d062b41c17feb6ae66bf91da3182a /drivers/mtd/nand/gpmi-nand/gpmi-nand.c | |
| parent | mtd: gpmi: add a new DT property to use the datasheet's minimum required ECC (diff) | |
| download | linux-dev-554cbc509f4ef95b0f06d04d94f0b0c2019dee26.tar.xz linux-dev-554cbc509f4ef95b0f06d04d94f0b0c2019dee26.zip | |
mtd: gpmi: Use devm_clk_get()
Using devm_clk_get() can make the code smaller and cleaner.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Huang Shijie <b32955@freescale.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Diffstat (limited to '')
| -rw-r--r-- | drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 21 |
1 files changed, 2 insertions, 19 deletions
diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c index 9c5911616a07..739f131e572c 100644 --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c @@ -582,21 +582,6 @@ acquire_err: return -EINVAL; } -static void gpmi_put_clks(struct gpmi_nand_data *this) -{ - struct resources *r = &this->resources; - struct clk *clk; - int i; - - for (i = 0; i < GPMI_CLK_MAX; i++) { - clk = r->clock[i]; - if (clk) { - clk_put(clk); - r->clock[i] = NULL; - } - } -} - static char *extra_clks_for_mx6q[GPMI_CLK_MAX] = { "gpmi_apb", "gpmi_bch", "gpmi_bch_apb", "per1_bch", }; @@ -609,7 +594,7 @@ static int gpmi_get_clks(struct gpmi_nand_data *this) int err, i; /* The main clock is stored in the first. */ - r->clock[0] = clk_get(this->dev, "gpmi_io"); + r->clock[0] = devm_clk_get(this->dev, "gpmi_io"); if (IS_ERR(r->clock[0])) { err = PTR_ERR(r->clock[0]); goto err_clock; @@ -625,7 +610,7 @@ static int gpmi_get_clks(struct gpmi_nand_data *this) if (extra_clks[i - 1] == NULL) break; - clk = clk_get(this->dev, extra_clks[i - 1]); + clk = devm_clk_get(this->dev, extra_clks[i - 1]); if (IS_ERR(clk)) { err = PTR_ERR(clk); goto err_clock; @@ -647,7 +632,6 @@ static int gpmi_get_clks(struct gpmi_nand_data *this) err_clock: dev_dbg(this->dev, "failed in finding the clocks.\n"); - gpmi_put_clks(this); return err; } @@ -687,7 +671,6 @@ exit_regs: static void release_resources(struct gpmi_nand_data *this) { - gpmi_put_clks(this); release_register_block(this); release_bch_irq(this); release_dma_channels(this); |