diff options
| author |   Wagner Ferenc <wferi@niif.hu> | 2007-12-06 23:40:32 -0800 |
|---|---|---|
| committer |   Jeff Garzik <jeff@garzik.org> | 2007-12-07 15:00:28 -0500 |
| commit | 8e4b9329080b7c37e3dcf4a7c435657d4d0f4816 (patch) | |
| tree | 600cf8b513b1727075adcd3b55a01208a2b0708e /drivers/net/bonding/bond_sysfs.c | |
| parent | bonding: Coding style: break line after the if condition (diff) | |
| download | linux-dev-8e4b9329080b7c37e3dcf4a7c435657d4d0f4816.tar.xz linux-dev-8e4b9329080b7c37e3dcf4a7c435657d4d0f4816.zip | |
bonding: Allow setting and querying xmit policy regardless of mode
From: Wagner Ferenc <wferi@niif.hu>
For consistency with the behaviour of the arp_ip_target option,
let /sys/class/net/bond0/bonding/xmit_hash_policy accept and report
current policy even if the bonding mode in effect does not use it.
Signed-off-by: Ferenc Wagner <wferi@niif.hu>
Acked-by: Jay Vosburgh <fubar@us.ibm.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/bonding/bond_sysfs.c | 21 |
1 files changed, 3 insertions, 18 deletions
diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding/bond_sysfs.c index 9de2c5284e27..11b76b352415 100644 --- a/drivers/net/bonding/bond_sysfs.c +++ b/drivers/net/bonding/bond_sysfs.c @@ -456,17 +456,11 @@ static ssize_t bonding_show_xmit_hash(struct device *d, struct device_attribute *attr, char *buf) { - int count = 0; struct bonding *bond = to_bond(d); - if ((bond->params.mode == BOND_MODE_XOR) || - (bond->params.mode == BOND_MODE_8023AD)) { - count = sprintf(buf, "%s %d\n", - xmit_hashtype_tbl[bond->params.xmit_policy].modename, - bond->params.xmit_policy); - } - - return count; + return sprintf(buf, "%s %d\n", + xmit_hashtype_tbl[bond->params.xmit_policy].modename, + bond->params.xmit_policy); } static ssize_t bonding_store_xmit_hash(struct device *d, @@ -484,15 +478,6 @@ static ssize_t bonding_store_xmit_hash(struct device *d, goto out; } - if ((bond->params.mode != BOND_MODE_XOR) && - (bond->params.mode != BOND_MODE_8023AD)) { - printk(KERN_ERR DRV_NAME - "%s: Transmit hash policy is irrelevant in this mode.\n", - bond->dev->name); - ret = -EPERM; - goto out; - } - new_value = bond_parse_parm((char *)buf, xmit_hashtype_tbl); if (new_value < 0) { printk(KERN_ERR DRV_NAME |