diff options
| author |   Wang Xiayang <xywang.sjtu@sjtu.edu.cn> | 2019-07-31 15:25:59 +0800 |
|---|---|---|
| committer |   Marc Kleine-Budde <mkl@pengutronix.de> | 2019-08-02 13:27:30 +0200 |
| commit | e787f19373b8a5fa24087800ed78314fd17b984a (patch) | |
| tree | e39c3589e8fb33010e26d42f9c8ea0dcddf5514f /drivers/net/can/usb/peak_usb/pcan_usb_core.c | |
| parent | can: sja1000: force the string buffer NULL-terminated (diff) | |
| download | linux-dev-e787f19373b8a5fa24087800ed78314fd17b984a.tar.xz linux-dev-e787f19373b8a5fa24087800ed78314fd17b984a.zip | |
can: peak_usb: force the string buffer NULL-terminated
strncpy() does not ensure NULL-termination when the input string size
equals to the destination buffer size IFNAMSIZ. The output string is
passed to dev_info() which relies on the NULL-termination.
Use strlcpy() instead.
This issue is identified by a Coccinelle script.
Signed-off-by: Wang Xiayang <xywang.sjtu@sjtu.edu.cn>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/can/usb/peak_usb/pcan_usb_core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_core.c b/drivers/net/can/usb/peak_usb/pcan_usb_core.c index 22b9c8e6d040..65dce642b86b 100644 --- a/drivers/net/can/usb/peak_usb/pcan_usb_core.c +++ b/drivers/net/can/usb/peak_usb/pcan_usb_core.c @@ -855,7 +855,7 @@ static void peak_usb_disconnect(struct usb_interface *intf) dev_prev_siblings = dev->prev_siblings; dev->state &= ~PCAN_USB_STATE_CONNECTED; - strncpy(name, netdev->name, IFNAMSIZ); + strlcpy(name, netdev->name, IFNAMSIZ); unregister_netdev(netdev); |