diff options
| author |   Vivien Didelot <vivien.didelot@savoirfairelinux.com> | 2016-05-13 20:38:23 -0400 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2016-05-16 13:46:24 -0400 |
| commit | 553eb544444e28749e2d752dee11e2ae4a3ecfb6 (patch) | |
| tree | 0cbe4d8f3cfba3393be578a5866ff48b029c5fd0 /drivers/net/dsa/mv88e6xxx.h | |
| parent | net: vrf: protect changes to private data with rcu (diff) | |
| download | linux-dev-553eb544444e28749e2d752dee11e2ae4a3ecfb6.tar.xz linux-dev-553eb544444e28749e2d752dee11e2ae4a3ecfb6.zip | |
net: dsa: mv88e6xxx: remove bridge work
Now that the bridge code defers the switchdev port state setting, there
is no need to defer the port STP state change within the mv88e6xxx code.
Thus get rid of the driver's bridge work code.
This also fixes a race condition where the DSA layer assumes that the
bridge code already set the unbridged port's STP state to Disabled
before restoring the Forwarding state.
As a consequence, this also fixes the FDB flush for the unbridged port
which now correctly occurs during the Forwarding to Disabled transition.
Fixes: 0bc05d585d38 ("switchdev: allow caller to explicitly request attr_set as deferred")
Reported-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/dsa/mv88e6xxx.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/drivers/net/dsa/mv88e6xxx.h b/drivers/net/dsa/mv88e6xxx.h index 40e8721ecfb1..36d0e1504de1 100644 --- a/drivers/net/dsa/mv88e6xxx.h +++ b/drivers/net/dsa/mv88e6xxx.h @@ -543,7 +543,6 @@ struct mv88e6xxx_vtu_stu_entry { struct mv88e6xxx_priv_port { struct net_device *bridge_dev; - u8 state; }; struct mv88e6xxx_priv_state { @@ -593,10 +592,6 @@ struct mv88e6xxx_priv_state { struct mv88e6xxx_priv_port ports[DSA_MAX_PORTS]; - DECLARE_BITMAP(port_state_update_mask, DSA_MAX_PORTS); - - struct work_struct bridge_work; - /* A switch may have a GPIO line tied to its reset pin. Parse * this from the device tree, and use it before performing * switch soft reset. |