diff options
| author |   yuval.shaia@oracle.com <yuval.shaia@oracle.com> | 2017-06-04 20:22:00 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-06-05 11:00:42 -0400 |
| commit | 82c01a84d5a9bd3b9347bb03eed2f05bbccef933 (patch) | |
| tree | af6cf232e9baf280280a00fcbbf89a568d37bf1b /drivers/net/ethernet/amd/pcnet32.c | |
| parent | net/dec: Make __de_get_link_ksettings return void (diff) | |
| download | linux-dev-82c01a84d5a9bd3b9347bb03eed2f05bbccef933.tar.xz linux-dev-82c01a84d5a9bd3b9347bb03eed2f05bbccef933.zip | |
net/{mii, smsc}: Make mii_ethtool_get_link_ksettings and smc_netdev_get_ecmd return void
Make return value void since functions never returns meaningfull value.
Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/amd/pcnet32.c')
| -rw-r--r-- | drivers/net/ethernet/amd/pcnet32.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/amd/pcnet32.c index 86369d7c9a0f..7f60d17819ce 100644 --- a/drivers/net/ethernet/amd/pcnet32.c +++ b/drivers/net/ethernet/amd/pcnet32.c @@ -731,12 +731,10 @@ static int pcnet32_get_link_ksettings(struct net_device *dev, { struct pcnet32_private *lp = netdev_priv(dev); unsigned long flags; - int r = -EOPNOTSUPP; spin_lock_irqsave(&lp->lock, flags); if (lp->mii) { mii_ethtool_get_link_ksettings(&lp->mii_if, cmd); - r = 0; } else if (lp->chip_version == PCNET32_79C970A) { if (lp->autoneg) { cmd->base.autoneg = AUTONEG_ENABLE; @@ -753,10 +751,9 @@ static int pcnet32_get_link_ksettings(struct net_device *dev, ethtool_convert_legacy_u32_to_link_mode( cmd->link_modes.supported, SUPPORTED_TP | SUPPORTED_AUI); - r = 0; } spin_unlock_irqrestore(&lp->lock, flags); - return r; + return 0; } static int pcnet32_set_link_ksettings(struct net_device *dev, |