diff options
| author |   Lendacky, Thomas <Thomas.Lendacky@amd.com> | 2014-11-20 11:03:32 -0600 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2014-11-21 15:19:10 -0500 |
| commit | 16edd34e9ebb4c0b63c69ada3abe106a309cb431 (patch) | |
| tree | 2ef35969ad3645425848f3dac765b3056a83cc84 /drivers/net/ethernet/amd/xgbe/xgbe.h | |
| parent | amd-xgbe: Add a read memory barrier to Tx/Rx path (diff) | |
| download | linux-dev-16edd34e9ebb4c0b63c69ada3abe106a309cb431.tar.xz linux-dev-16edd34e9ebb4c0b63c69ada3abe106a309cb431.zip | |
amd-xgbe: Tx engine must not be active before stopping it
If the Tx engine is told to stop while it is actively processing Tx
descriptors it is possible that the Tx descriptor(s) will not be closed
out properly. When the Tx engine is restarted this could result in the
driver being stuck on the improperly closed descriptor.
Update the driver to wait for the Tx engine to be in a stopped or
suspended state before issuing the stop command.
This has not been an issue to date, but it's a good safe-guard to have.
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/amd/xgbe/xgbe.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe.h b/drivers/net/ethernet/amd/xgbe/xgbe.h index 901fb1fe5d0d..46ce54459121 100644 --- a/drivers/net/ethernet/amd/xgbe/xgbe.h +++ b/drivers/net/ethernet/amd/xgbe/xgbe.h @@ -147,6 +147,7 @@ #define XGBE_MAX_DMA_CHANNELS 16 #define XGBE_MAX_QUEUES 16 +#define XGBE_DMA_STOP_TIMEOUT 5 /* DMA cache settings - Outer sharable, write-back, write-allocate */ #define XGBE_DMA_OS_AXDOMAIN 0x2 |