diff options
| author |   Iyappan Subramanian <isubramanian@apm.com> | 2017-05-10 13:45:10 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-05-16 11:41:11 -0400 |
| commit | 8aba8474181070a30f56ffd19359f5d80665175e (patch) | |
| tree | aa4c16c1409054f2a1a78b1dc89c7ce71f015131 /drivers/net/ethernet/apm/xgene/xgene_enet_main.c | |
| parent | drivers: net: xgene: Workaround for HW errata 10GE_10/ENET_15 (diff) | |
| download | linux-dev-8aba8474181070a30f56ffd19359f5d80665175e.tar.xz linux-dev-8aba8474181070a30f56ffd19359f5d80665175e.zip | |
drivers: net: xgene: Fix redundant prefetch buffer cleanup
Prefetch buffer cleanup code was called twice, causing EDAC to
report errors during reboot.
[ 1130.972475] xgene-edac 78800000.edac: IOB bridge agent (BA) transaction
error
[ 1130.979584] xgene-edac 78800000.edac: IOB BA write response error
[ 1130.985648] xgene-edac 78800000.edac: IOB BA write access at 0x00.00000000
()
[ 1130.993612] xgene-edac 78800000.edac: IOB BA requestor ID 0x00002400
[ 1131.000242] xgene-edac 78800000.edac: IOB bridge agent (BA) transaction
error
...
This patch fixes the errors by,
- removing the redundant prefetch buffer cleanup from port_ops->shutdown()
- moving port_ops->shutdown() after delete_rings()
Signed-off-by: Iyappan Subramanian <isubramanian@apm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c index 01e389df3aff..21cd4ef3e5eb 100644 --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c @@ -2159,8 +2159,8 @@ static int xgene_enet_remove(struct platform_device *pdev) xgene_enet_mdio_remove(pdata); unregister_netdev(ndev); - pdata->port_ops->shutdown(pdata); xgene_enet_delete_desc_rings(pdata); + pdata->port_ops->shutdown(pdata); free_netdev(ndev); return 0; |