aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/aquantia
diff options
context:
space:
mode:
authorGustavo A. R. Silva <gustavo@embeddedor.com>2019-10-28 02:04:47 -0500
committerDavid S. Miller <davem@davemloft.net>2019-10-29 16:42:17 -0700
commit76d7774e203d422edb6b8c6db800478ca029fde5 (patch)
tree24b2f66b693550521d9f5d9cc2bed5fafd5f765c /drivers/net/ethernet/aquantia
parentnet: aquantia: remove unused including <linux/version.h> (diff)
downloadlinux-dev-76d7774e203d422edb6b8c6db800478ca029fde5.tar.xz
linux-dev-76d7774e203d422edb6b8c6db800478ca029fde5.zip
net: aquantia: fix error handling in aq_ptp_poll
Fix currenty ignored returned error by properly checking *err* after calling aq_nic->aq_hw_ops->hw_ring_hwts_rx_fill(). Addresses-Coverity-ID: 1487357 ("Unused value") Fixes: 04a1839950d9 ("net: aquantia: implement data PTP datapath") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Reviewed-by: Igor Russkikh <irusskikh@marvell.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/aquantia')
-rw-r--r--drivers/net/ethernet/aquantia/atlantic/aq_ptp.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c b/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c
index 4ca36003c6ca..8175513e48c9 100644
--- a/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c
+++ b/drivers/net/ethernet/aquantia/atlantic/aq_ptp.c
@@ -678,6 +678,8 @@ static int aq_ptp_poll(struct napi_struct *napi, int budget)
err = aq_nic->aq_hw_ops->hw_ring_hwts_rx_fill(aq_nic->aq_hw,
&aq_ptp->hwts_rx);
+ if (err < 0)
+ goto err_exit;
was_cleaned = true;
}