aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/net/ethernet/aurora/nb8800.c
diff options
context:
space:
mode:
authorWei Yongjun <weiyongjun1@huawei.com>2016-10-17 15:31:58 +0000
committerDavid S. Miller <davem@davemloft.net>2016-10-17 13:12:05 -0400
commitca8eddc2759c949940720b5dc347e93bc981f5f2 (patch)
tree0071599d897f97844acb88497580bc93891c42fe /drivers/net/ethernet/aurora/nb8800.c
parentfjes: fix format string for trace output (diff)
downloadlinux-dev-ca8eddc2759c949940720b5dc347e93bc981f5f2.tar.xz
linux-dev-ca8eddc2759c949940720b5dc347e93bc981f5f2.zip
net: ethernet: nb8800: fix error return code in nb8800_open()
Fix to return error code -ENODEV from the of_phy_connect() error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Acked-by: Mans Rullgard <mans@mansr.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/aurora/nb8800.c')
-rw-r--r--drivers/net/ethernet/aurora/nb8800.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/ethernet/aurora/nb8800.c b/drivers/net/ethernet/aurora/nb8800.c
index 453dc0967125..99c40552ea90 100644
--- a/drivers/net/ethernet/aurora/nb8800.c
+++ b/drivers/net/ethernet/aurora/nb8800.c
@@ -975,8 +975,10 @@ static int nb8800_open(struct net_device *dev)
phydev = of_phy_connect(dev, priv->phy_node,
nb8800_link_reconfigure, 0,
priv->phy_mode);
- if (!phydev)
+ if (!phydev) {
+ err = -ENODEV;
goto err_free_irq;
+ }
nb8800_pause_adv(dev);